Openshift machine api#147
Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom Feb 1, 2019
Merged
Conversation
Member
Author
openshift-ci-robot
added
the
size/XXL
enxebre
added
the
do-not-merge/hold
enxebre
force-pushed
the
openshift-machine-api
branch
8 times, most recently
from
d7deb21 to
11cdc21
Compare
enxebre
force-pushed
the
openshift-machine-api
branch
from
11cdc21 to
801f8d8
Compare
enxebre
force-pushed
the
openshift-machine-api
branch
from
801f8d8 to
72b4e7d
Compare
Member
Author
|
/test e2e-aws |
Member
Author
|
/test e2e-aws |
We are mirroring the cluster API types under machine.openshift.io group. For the sake of transparency we are making this explicit in the import path. This allows both libraries upstream and openshift ot be consumed simultaneously by other tooling. We aim to consilidate back with upstream once there's a relase stable enough
enxebre
force-pushed
the
openshift-machine-api
branch
from
72b4e7d to
b673340
Compare
ingvagabund
reviewed
Feb 1, 2019
| version="v0.1.1" | ||
| [[override]] | ||
| name = "k8s.io/api" | ||
| # revision for tag "kubernetes-1.11.2" |
Member
There was a problem hiding this comment.
version = "kubernetes-1.11.2" does not work? The same for other override's cases.
Member
Author
There was a problem hiding this comment.
this is consolidating with mao. In a follow up we need to pin all to 1.12.* https://jira.coreos.com/browse/CLOUD-367
Member
Author
|
/test e2e |
1 similar comment
Member
Author
|
/test e2e |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
enxebre
removed
the
do-not-merge/hold
This was referenced Feb 1, 2019
michaelgugino
pushed a commit
to mgugino-upstream-stage/cluster-api-provider-aws
that referenced
this pull request
Feb 12, 2020
Signed-off-by: Vince Prignano <vince@vincepri.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are mirroring the API types under machine.openshift.io group. For the sake of transparency we are making this explicit in the import path. This allows both libraries upstream and openshift ot be consumed simultaneously by other tooling. We aim to consilidate back with upstream once there's a relase stable enough
Needs openshift/machine-api-operator#188 so the new nodelink controller allows
ci/jenkins/e2epass with the new group ande2e-awsande2e-aws-operatorpass with the deprecated provider image